> On Jan. 8, 2019, 10:04 a.m., Peter Vary wrote: > > Thanks for the patch! > > Two nits below. > > Also a bit concerned about the size calculation - seems ok, but it would be > > good to have a few test case which validates the contentsummary > > calculations (when every path is cached/only few patch is cached/no path is > > cached), so we can be sure that further changes will not break the > > functionality. > > > > What do you think? > > > > Peter
Thank you Peter for the review. This functionality is unit tested already. Do you have suggestions for additional unit tests? https://github.com/apache/hive/blob/ae008b79b5d52ed6a38875b73025a505725828eb/ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69683/#review211758 ----------------------------------------------------------- On Jan. 14, 2019, 3:36 p.m., David Mollitor wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69683/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2019, 3:36 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > Improve performance of method getInputSummary by changing data structures and > allowing multiple threads to do calculations. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 2ff9ad3 > > > Diff: https://reviews.apache.org/r/69683/diff/2/ > > > Testing > ------- > > Unit > > > Thanks, > > David Mollitor > >
