----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69683/#review211758 -----------------------------------------------------------
Thanks for the patch! Two nits below. Also a bit concerned about the size calculation - seems ok, but it would be good to have a few test case which validates the contentsummary calculations (when every path is cached/only few patch is cached/no path is cached), so we can be sure that further changes will not break the functionality. What do you think? Peter ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java Lines 2466-2467 (original), 2477-2478 (patched) <https://reviews.apache.org/r/69683/#comment297356> nit: This is just a formatting change. Please remove. ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java Line 2503 (original), 2514-2515 (patched) <https://reviews.apache.org/r/69683/#comment297357> nit: This is just a formatting change. Please remove. - Peter Vary On jan. 7, 2019, 2:26 du, David Mollitor wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69683/ > ----------------------------------------------------------- > > (Updated jan. 7, 2019, 2:26 du) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > Improve performance of method getInputSummary by changing data structures and > allowing multiple threads to do calculations. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java d0f6451 > > > Diff: https://reviews.apache.org/r/69683/diff/1/ > > > Testing > ------- > > Unit > > > Thanks, > > David Mollitor > >
