----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68648/ -----------------------------------------------------------
(Updated Sept. 7, 2018, 6:42 p.m.) Review request for hive, Gopal V and Matt McCline. Changes ------- Addressed concerns from Matt's review. Replaced the constant string _bucket_number with a UDF GenericUDFBucketNumber() to make sure _bucket_number could be uaed as a legitimate string in queries. Bugs: HIVE-20510 https://issues.apache.org/jira/browse/HIVE-20510 Repository: hive-git Description ------- Vectorization : Support loading bucketed tables using sorted dynamic partition optimizer. Added a new VectorExpression BucketNumberExpression to evaluate _bucket_number. Made the loops as tight as possible. Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 8bf0a9c77d ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 57f7c0108e ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/BucketNumExpression.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkObjectHashOperator.java 5ab59c9c61 ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java 51010aac85 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBucketNumber.java PRE-CREATION ql/src/test/queries/clientpositive/dynpart_sort_opt_vectorization.q 435cdaddd0 ql/src/test/results/clientpositive/llap/dynpart_sort_opt_vectorization.q.out 22f0a31eb3 Diff: https://reviews.apache.org/r/68648/diff/2/ Changes: https://reviews.apache.org/r/68648/diff/1-2/ Testing ------- Thanks, Deepak Jaiswal