----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68648/#review208396 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java Lines 865 (patched) <https://reviews.apache.org/r/68648/#comment292287> In order for EXPLAIN VECTORIZATION to see the proper information on BucketNumExpression you need to call ve.setInputTypeInfos(inputTypeInfo); ve.setOutputTypeInfo(outputTypeInfo); on the new VectorExpression. Probably in a separate method. - Matt McCline On Sept. 6, 2018, 6:47 a.m., Deepak Jaiswal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68648/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2018, 6:47 a.m.) > > > Review request for hive, Gopal V and Matt McCline. > > > Bugs: HIVE-20510 > https://issues.apache.org/jira/browse/HIVE-20510 > > > Repository: hive-git > > > Description > ------- > > Vectorization : Support loading bucketed tables using sorted dynamic > partition optimizer. > Added a new VectorExpression BucketNumberExpression to evaluate > _bucket_number. > Made the loops as tight as possible. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java > 57f7c0108e > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/BucketNumExpression.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkObjectHashOperator.java > 5ab59c9c61 > ql/src/test/queries/clientpositive/dynpart_sort_opt_vectorization.q > 435cdaddd0 > > ql/src/test/results/clientpositive/llap/dynpart_sort_opt_vectorization.q.out > 22f0a31eb3 > > > Diff: https://reviews.apache.org/r/68648/diff/1/ > > > Testing > ------- > > > Thanks, > > Deepak Jaiswal > >
