> On June 27, 2018, 2:07 p.m., Peter Vary wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 1260 (patched) > > <https://reviews.apache.org/r/67753/diff/2/?file=2046286#file2046286line1260> > > > > Probably it would be good to check the conf first, and check the > > existance of the directory only it is required by the conf. Checking the FS > > can take some time. > > Are we sure that the location is not null at this stage?
Done > On June 27, 2018, 2:07 p.m., Peter Vary wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestMetaCreateObjects.java > > Lines 52 (patched) > > <https://reviews.apache.org/r/67753/diff/2/?file=2046289#file2046289line52> > > > > When starting an Embedded metastore, please set the jdbc url to a > > unique value, like here: > > > > https://github.com/apache/hive/blob/master/standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/MetaStoreFactoryForTests.java#L89-L90 > > > > Otherwise when multiple test run in parallel they will start the same > > derby database for their tests which can cause unexpected problems. Done > On June 27, 2018, 2:07 p.m., Peter Vary wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestMetaCreateObjects.java > > Lines 79 (patched) > > <https://reviews.apache.org/r/67753/diff/2/?file=2046289#file2046289line79> > > > > Have you checked, that we really need this? AFAIK setting locationUri > > should be enough Done > On June 27, 2018, 2:07 p.m., Peter Vary wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestMetaCreateObjects.java > > Lines 103 (patched) > > <https://reviews.apache.org/r/67753/diff/2/?file=2046289#file2046289line103> > > > > Have you checked, that we really need this? AFAIK setting locationUri > > should be enough Done - Oleksiy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67753/#review205421 ----------------------------------------------------------- On June 27, 2018, 3:20 p.m., Oleksiy Sayankin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67753/ > ----------------------------------------------------------- > > (Updated June 27, 2018, 3:20 p.m.) > > > Review request for hive, Zoltan Haindrich and Zoltan Haindrich. > > > Repository: hive-git > > > Description > ------- > > Added hive.metastore.allow.new.db.in.existing.directory property > > > Diffs > ----- > > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > e9d7e7c397 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > f3b909ca44 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java > 963e12f9d8 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestMetaCreateObjects.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/67753/diff/3/ > > > Testing > ------- > > > Thanks, > > Oleksiy Sayankin > >
