----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67753/#review205424 -----------------------------------------------------------
Thanks for the fixes! standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java Lines 526 (patched) <https://reviews.apache.org/r/67753/#comment288332> Are we sure that the location is not null at this stage? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestMetaCreateObjects.java Line 49 (original), 47 (patched) <https://reviews.apache.org/r/67753/#comment288331> this is exactly the same as in the default config, so we will still have a conglict here :) We might want to try: jdbc:derby:memory:${test.tmp.dir}/junit_metastore_db_test_meta_create_objects;create=true - Peter Vary On jún. 27, 2018, 12:20 du, Oleksiy Sayankin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67753/ > ----------------------------------------------------------- > > (Updated jún. 27, 2018, 12:20 du) > > > Review request for hive, Zoltan Haindrich and Zoltan Haindrich. > > > Repository: hive-git > > > Description > ------- > > Added hive.metastore.allow.new.db.in.existing.directory property > > > Diffs > ----- > > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > e9d7e7c397 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > f3b909ca44 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java > 963e12f9d8 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestMetaCreateObjects.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/67753/diff/3/ > > > Testing > ------- > > > Thanks, > > Oleksiy Sayankin > >
