> On May 25, 2018, 4:43 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobMonitor.java > > Line 304 (original), 231 (patched) > > <https://reviews.apache.org/r/67263/diff/1/?file=2027540#file2027540line306> > > > > whats the point of this class? > > Bharathkrishna Guruvayoor Murali wrote: > I used this class to follow same pattern as in tez. I will add the logic > similar to RenderStrategy used in tez while adding beeline progress bar, so > this should be useful. > > Sahil Takiar wrote: > Ok, can this be a private class? Is it used outside `SparkJobMonitor`? > > Bharathkrishna Guruvayoor Murali wrote: > Not used outside SparkJobMonitor. Making private
I actually removed this class, because I was using the static class in a "non-static" kind of way. Just donot want to have code with wrong pattern even though it will bee changed soon. I will add it when it is actually required, ie. later when I need to introduce progress bar in beeline. - Bharathkrishna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67263/#review203891 ----------------------------------------------------------- On June 1, 2018, 4:58 a.m., Bharathkrishna Guruvayoor Murali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67263/ > ----------------------------------------------------------- > > (Updated June 1, 2018, 4:58 a.m.) > > > Review request for hive, Sahil Takiar and Vihang Karajgaonkar. > > > Bugs: HIVE-19602 > https://issues.apache.org/jira/browse/HIVE-19602 > > > Repository: hive-git > > > Description > ------- > > Refactor inplace progress code in Hive-on-spark progress monitor to use > ProgressMonitor instance > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobMonitor.java > 7afd8864075aa0d9708274eea8839c662324c732 > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkProgressMonitor.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/67263/diff/3/ > > > Testing > ------- > > > Thanks, > > Bharathkrishna Guruvayoor Murali > >
