----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67263/#review203993 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobMonitor.java Line 340 (original), 234 (patched) <https://reviews.apache.org/r/67263/#comment286394> add some javadocs for this class ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkProgressMonitor.java Lines 12 (patched) <https://reviews.apache.org/r/67263/#comment286393> can you add some javadocs for this class ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkProgressMonitor.java Lines 18 (patched) <https://reviews.apache.org/r/67263/#comment286392> this can be package private right? - Sahil Takiar On May 23, 2018, 5:32 a.m., Bharathkrishna Guruvayoor Murali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67263/ > ----------------------------------------------------------- > > (Updated May 23, 2018, 5:32 a.m.) > > > Review request for hive, Sahil Takiar and Vihang Karajgaonkar. > > > Bugs: HIVE-19602 > https://issues.apache.org/jira/browse/HIVE-19602 > > > Repository: hive-git > > > Description > ------- > > Refactor inplace progress code in Hive-on-spark progress monitor to use > ProgressMonitor instance > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobMonitor.java > 7afd8864075aa0d9708274eea8839c662324c732 > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkProgressMonitor.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/67263/diff/1/ > > > Testing > ------- > > > Thanks, > > Bharathkrishna Guruvayoor Murali > >
