> On May 23, 2018, 9:43 p.m., Ashutosh Chauhan wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Lines 2424 (patched) > > <https://reviews.apache.org/r/67125/diff/1/?file=2022633#file2022633line2424> > > > > Returning concatenated table Name + Dbname is error prone. Lets make > > this return List <catName, dbName, tablename> > > Sergey Shelukhin wrote: > This seems to be a standard approach in Hive to pass around the full > name(s). > In fact some existing APIs for metastore return catalog+db in one string, > and Hive uses full table name all over the place. > I don't think either is error-prone and requires String[]...
I dont agree. Yes, we use single string for dbName + tblName, but we want to change that in future. Motivation is to allow all chars in names (including + and unicode). There in fact is already a jira to do this change. Lets not introduce at one more place in a new code. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67125/#review203694 ----------------------------------------------------------- On May 26, 2018, 1:30 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67125/ > ----------------------------------------------------------- > > (Updated May 26, 2018, 1:30 a.m.) > > > Review request for hive, Ashutosh Chauhan and Seong (Steve) Yeom. > > > Repository: hive-git > > > Description > ------- > > see jira. This should eventually integrate with ACID stats to determine what > stats are out of date, when that is done. Probably in separate jira if this > goes in first. > > > Diffs > ----- > > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java > 3d6fda6bd4 > ql/src/java/org/apache/hadoop/hive/ql/DriverUtils.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 6c56212c9e > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUpdaterThread.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > 982b180761 > ql/src/test/org/apache/hadoop/hive/ql/stats/TestStatsUpdaterThread.java > PRE-CREATION > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > 9ab9e85742 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 92d2e3f368 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 5bb1985025 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 13ccdb145e > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java > ce7d2861dd > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > b223920e82 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/EnumValidator.java > PRE-CREATION > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > 114d5da205 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > f6899be750 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > 98a85cc758 > > > Diff: https://reviews.apache.org/r/67125/diff/2/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
