----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67125/#review203694 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUpdaterThread.java Lines 66 (patched) <https://reviews.apache.org/r/67125/#comment285971> Is this correct? ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUpdaterThread.java Lines 138 (patched) <https://reviews.apache.org/r/67125/#comment285965> Should add a comment along the line of: "Security is turned off. So, we can execute with annonymous user." ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUpdaterThread.java Lines 557 (patched) <https://reviews.apache.org/r/67125/#comment285968> This will compute basic and column stats. I assume this is what you want. standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java Lines 2424 (patched) <https://reviews.apache.org/r/67125/#comment285972> Returning concatenated table Name + Dbname is error prone. Lets make this return List <catName, dbName, tablename> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java Lines 2425 (patched) <https://reviews.apache.org/r/67125/#comment285969> Currently it will fetch all tables (acid or not). Is that intentional? standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java Lines 1642 (patched) <https://reviews.apache.org/r/67125/#comment285973> Return value should be List<List<CatName, DBname, TblName>> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java Lines 738 (patched) <https://reviews.apache.org/r/67125/#comment285970> I think this timeunit should be in minutes since this task need to run more frequently than that. That will make this config less error-prone. Default value : 1 hour. - Ashutosh Chauhan On May 15, 2018, 4:55 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67125/ > ----------------------------------------------------------- > > (Updated May 15, 2018, 4:55 a.m.) > > > Review request for hive, Ashutosh Chauhan and Seong (Steve) Yeom. > > > Repository: hive-git > > > Description > ------- > > see jira. This should eventually integrate with ACID stats to determine what > stats are out of date, when that is done. Probably in separate jira if this > goes in first. > > > Diffs > ----- > > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java > 3d6fda6bd4 > ql/src/java/org/apache/hadoop/hive/ql/DriverUtils.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 89129f99fe > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUpdaterThread.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > b698c84080 > ql/src/test/org/apache/hadoop/hive/ql/stats/TestStatsUpdaterThread.java > PRE-CREATION > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > 0be0aaa10c > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 92d2e3f368 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 48f77b9878 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 264fdb9db9 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java > ce7d2861dd > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > b223920e82 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/EnumValidator.java > PRE-CREATION > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > 114d5da205 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > f6899be750 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > 98a85cc758 > > > Diff: https://reviews.apache.org/r/67125/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
