+1 - Hoping for something like this for a long while! Thanks for taking this up all!
> On May 15, 2018, at 5:44 PM, Jesus Camacho Rodriguez <jcama...@apache.org> > wrote: > > Forgot to mention the length of the vote in original message. > > Let's leave the vote open for a shorter period than usual, for instance 48 > hours, i.e., till Wednesday 10pm PST. Situation can only get worse than it is > now if we do not take action for a longer period. > > As Alan suggested, vote passes if there is a lazy majority (at least 3 votes, > more +1s than -1s). > > Thanks, > Jesús > > > On 5/15/18, 8:37 AM, "Andrew Sherman" <asher...@cloudera.com> wrote: > > +1 > > On Tue, May 15, 2018 at 2:34 AM Rui Li <lirui.fu...@gmail.com> wrote: > >> +1 >> >> On Tue, May 15, 2018 at 2:24 PM, Prasanth Jayachandran < >> pjayachand...@hortonworks.com> wrote: >> >>> +1 >>> >>> >>> >>> Thanks >>> Prasanth >>> >>> >>> >>> On Mon, May 14, 2018 at 10:44 PM -0700, "Jesus Camacho Rodriguez" < >>> jcama...@apache.org<mailto:jcama...@apache.org>> wrote: >>> >>> >>> After work has been done to ignore most of the tests that were failing >>> consistently/intermittently [1], I wanted to start this vote to gather >>> support from the community to be stricter wrt committing patches to Hive. >>> The committers guide [2] already specifies that a +1 should be obtained >>> before committing, but there is another clause that allows committing >> under >>> the presence of flaky tests (clause 4). Flaky tests are as good as having >>> no tests, hence I propose to remove clause 4 and enforce the +1 from >>> testing infra before committing. >>> >>> >>> >>> As I see it, by enforcing that we always get a +1 from the testing infra >>> before committing, 1) we will have a more stable project, and 2) we will >>> have another incentive as a community to create a more robust testing >>> infra, e.g., replacing flaky tests for similar unit tests that are not >>> flaky, trying to decrease running time for tests, etc. >>> >>> >>> >>> Please, share your thoughts about this. >>> >>> >>> >>> Here is my +1. >>> >>> >>> >>> Thanks, >>> >>> Jes?s >>> >>> >>> >>> [1] http://mail-archives.apache.org/mod_mbox/hive-dev/201805. >>> mbox/%3C63023673-AEE5-41A9-BA52-5A5DFB2078B6%40apache.org%3E >>> >>> [2] https://cwiki.apache.org/confluence/display/Hive/ >>> HowToCommit#HowToCommit-PreCommitruns,andcommittingpatches >>> >>> >>> >>> >>> >> >> >> -- >> Best regards! >> Rui Li >> > > >
