> On March 22, 2018, 11:03 a.m., Peter Vary wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Lines 154-158 (original), 154-158 (patched) > > <https://reviews.apache.org/r/66188/diff/2/?file=1984629#file1984629line154> > > > > It might be a good idea, to use this around our batching as well: > > - DatabaseProduct.needsInBatching(dbType) > > > > What do you think @Aihua? > > Aihua Xu wrote: > Thanks Peter for reviewing. This is slightly different problem. In > directSQL, some databases may not need batch, some do. While in DN, the > limitation is in DN, so it applies to all the databases.
Makes sense. Thanks for the clarification! - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66188/#review199751 ----------------------------------------------------------- On April 23, 2018, 10:51 p.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66188/ > ----------------------------------------------------------- > > (Updated April 23, 2018, 10:51 p.m.) > > > Review request for hive, Alexander Kolbasov and Yongzhi Chen. > > > Repository: hive-git > > > Description > ------- > > If the table contains a lot of columns e.g, 5k, simple table rename would > fail with the following stack trace. The issue is datanucleus can't handle > the query with lots of colName='c1' && colName='c2' && ... . > > I'm breaking the query into multiple smaller queries and then we aggregate > the result together. > > > Diffs > ----- > > ql/src/test/queries/clientpositive/alter_rename_table.q 53fb230cf6 > ql/src/test/results/clientpositive/alter_rename_table.q.out 732d8a28d8 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/Batchable.java > PRE-CREATION > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 997f5fdb88 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 125d5a79f2 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > 59749e4947 > > > Diff: https://reviews.apache.org/r/66188/diff/3/ > > > Testing > ------- > > Manual test has been done for large column of tables. > > > Thanks, > > Aihua Xu > >
