> On April 17, 2018, 4:49 p.m., Yongzhi Chen wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Lines 7730 (patched) > > <https://reviews.apache.org/r/66188/diff/2/?file=1984630#file1984630line7731> > > > > Should you call addQueryAfterUse and closeAllQueries ? That's how do > > you release the resources held by the batch queries?
In this change, I reuse single query to perform multiple queries and then release the query using queryWrapper. I did check how these two are used. Seems it's misused in other places that whenever there is new query, we created a new Query object which is not necessary. We can improve the logic to reuse the same Query object. It doesn't seem to be necessary. - Aihua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66188/#review201323 ----------------------------------------------------------- On March 21, 2018, 6:57 p.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66188/ > ----------------------------------------------------------- > > (Updated March 21, 2018, 6:57 p.m.) > > > Review request for hive, Alexander Kolbasov and Yongzhi Chen. > > > Repository: hive-git > > > Description > ------- > > If the table contains a lot of columns e.g, 5k, simple table rename would > fail with the following stack trace. The issue is datanucleus can't handle > the query with lots of colName='c1' && colName='c2' && ... . > > I'm breaking the query into multiple smaller queries and then we aggregate > the result together. > > > Diffs > ----- > > ql/src/test/queries/clientpositive/alter_rename_table.q 2061850540 > ql/src/test/results/clientpositive/alter_rename_table.q.out 732d8a28d8 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/Batchable.java > PRE-CREATION > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 6ead20aeaf > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 88d88ed4df > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > 9f822564bd > > > Diff: https://reviews.apache.org/r/66188/diff/2/ > > > Testing > ------- > > Manual test has been done for large column of tables. > > > Thanks, > > Aihua Xu > >
