----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66185/#review200227 -----------------------------------------------------------
beeline/src/java/org/apache/hive/beeline/hs2connection/HS2ConnectionFileUtils.java Lines 189 (patched) <https://reviews.apache.org/r/66185/#comment280885> this might end up matching substrings of new properties. use delimiters in the search to avoid that ? Alternatively, should we just apply the configs from jdbcConnectionParams at the end ? If the application is in sequence by the jdbc driver, then we don't have to bother overriding it, the last values get picked up. (if jdbc driver already does that) - Thejas Nair On March 28, 2018, 8:27 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66185/ > ----------------------------------------------------------- > > (Updated March 28, 2018, 8:27 p.m.) > > > Review request for hive, Thejas Nair and Vihang Karajgaonkar. > > > Bugs: HIVE-18963 > https://issues.apache.org/jira/browse/HIVE-18963 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-18963 > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLine.java 402fadddde > > beeline/src/java/org/apache/hive/beeline/hs2connection/BeelineConfFileParseException.java > PRE-CREATION > > beeline/src/java/org/apache/hive/beeline/hs2connection/BeelineHS2ConnectionFileParseException.java > acddf82a67 > > beeline/src/java/org/apache/hive/beeline/hs2connection/BeelineSiteParseException.java > PRE-CREATION > > beeline/src/java/org/apache/hive/beeline/hs2connection/BeelineSiteParser.java > PRE-CREATION > > beeline/src/java/org/apache/hive/beeline/hs2connection/HS2ConnectionFileParser.java > b769e8581f > > beeline/src/java/org/apache/hive/beeline/hs2connection/HS2ConnectionFileUtils.java > f635b40633 > > beeline/src/java/org/apache/hive/beeline/hs2connection/UserHS2ConnectionFileParser.java > 2801ebee09 > beeline/src/main/resources/BeeLine.properties 6fca953836 > > beeline/src/test/org/apache/hive/beeline/hs2connection/TestUserHS2ConnectionFileParser.java > 1d17887417 > beeline/src/test/resources/test-hs2-named-connection-config.xml > PRE-CREATION > > itests/hive-unit/src/test/java/org/apache/hive/beeline/hs2connection/BeelineWithHS2ConnectionFileTestBase.java > 3da31ad8a9 > jdbc/src/java/org/apache/hive/jdbc/Utils.java 6d7787da7d > > > Diff: https://reviews.apache.org/r/66185/diff/2/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
