----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66185/#review200213 -----------------------------------------------------------
beeline/src/java/org/apache/hive/beeline/BeeLine.java Lines 1110 (patched) <https://reviews.apache.org/r/66185/#comment280866> it would be useful to print the URL as part of this error message. beeline/src/java/org/apache/hive/beeline/hs2connection/BeelineConfFileParseException.java Lines 21 (patched) <https://reviews.apache.org/r/66185/#comment280867> why is this needed ? This is not marked as serializable. beeline/src/java/org/apache/hive/beeline/hs2connection/BeelineSiteParseException.java Lines 21 (patched) <https://reviews.apache.org/r/66185/#comment280868> looks unnecessary beeline/src/java/org/apache/hive/beeline/hs2connection/HS2ConnectionFileUtils.java Lines 148 (patched) <https://reviews.apache.org/r/66185/#comment280869> javadoc describing what this is supposed to do would be useful beeline/src/java/org/apache/hive/beeline/hs2connection/HS2ConnectionFileUtils.java Lines 156-157 (patched) <https://reviews.apache.org/r/66185/#comment280870> String host = getMergedProperty(userConnectionProperties, jdbcConnectionParams, HS2ConnectionFileParser.HOST_PROPERTY_KEY, null /*default value*/); would be enable code re-use between this and defaultDb value extraction. - Thejas Nair On March 28, 2018, 8:27 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66185/ > ----------------------------------------------------------- > > (Updated March 28, 2018, 8:27 p.m.) > > > Review request for hive, Thejas Nair and Vihang Karajgaonkar. > > > Bugs: HIVE-18963 > https://issues.apache.org/jira/browse/HIVE-18963 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-18963 > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLine.java 402fadddde > > beeline/src/java/org/apache/hive/beeline/hs2connection/BeelineConfFileParseException.java > PRE-CREATION > > beeline/src/java/org/apache/hive/beeline/hs2connection/BeelineHS2ConnectionFileParseException.java > acddf82a67 > > beeline/src/java/org/apache/hive/beeline/hs2connection/BeelineSiteParseException.java > PRE-CREATION > > beeline/src/java/org/apache/hive/beeline/hs2connection/BeelineSiteParser.java > PRE-CREATION > > beeline/src/java/org/apache/hive/beeline/hs2connection/HS2ConnectionFileParser.java > b769e8581f > > beeline/src/java/org/apache/hive/beeline/hs2connection/HS2ConnectionFileUtils.java > f635b40633 > > beeline/src/java/org/apache/hive/beeline/hs2connection/UserHS2ConnectionFileParser.java > 2801ebee09 > beeline/src/main/resources/BeeLine.properties 6fca953836 > > beeline/src/test/org/apache/hive/beeline/hs2connection/TestUserHS2ConnectionFileParser.java > 1d17887417 > beeline/src/test/resources/test-hs2-named-connection-config.xml > PRE-CREATION > > itests/hive-unit/src/test/java/org/apache/hive/beeline/hs2connection/BeelineWithHS2ConnectionFileTestBase.java > 3da31ad8a9 > jdbc/src/java/org/apache/hive/jdbc/Utils.java 6d7787da7d > > > Diff: https://reviews.apache.org/r/66185/diff/2/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
