----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65415/#review196696 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines 1947 (patched) <https://reviews.apache.org/r/65415/#comment276493> I think this should be in somewhere in the BasicStat related class; or this can't be moved there? ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java Line 127 (original), 127 (patched) <https://reviews.apache.org/r/65415/#comment276489> It seems to me that the old conditionals have done almost the same...by changing p.isAcid to p.isTransactional ; I don't see any difference; since if its being rewritten the flag will be turned on ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java Line 157 (original), 162 (patched) <https://reviews.apache.org/r/65415/#comment276488> I feel that currently the stats system is half-blind when it comes to acid tables...because the autogather operations are somewhat useless on them... I was thinking about the following: removing this condition to collect stats even in case basic stats are off; would enable the stats to gather a total "rowtraffic" - which might be good enough for an estimation ; and it may give the join order optimization a chance to do its job better for acid/insert_only tables which have not been updated explicitly updated for a long time... This could be probably done as a separate change (because it will probably rewrite every second q.out) - what do you think about it? standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java Lines 650 (patched) <https://reviews.apache.org/r/65415/#comment276490> I might be missing something but I don't see why should quickstats be calculated differently for transactional tables...quickstats is num_files and total bytes on disk - these things apply to acid tables as well standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java Lines 674 (patched) <https://reviews.apache.org/r/65415/#comment276491> I don't understand why standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java Lines 676 (patched) <https://reviews.apache.org/r/65415/#comment276492> I totally agree...it's very inconvinient to have this in the metastore - Zoltan Haindrich On Jan. 31, 2018, 2:15 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65415/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2018, 2:15 a.m.) > > > Review request for hive and Eugene Koifman. > > > Repository: hive-git > > > Description > ------- > > f.,v fbghdscd > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 114d455ff8 > > ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadPartitions.java > bad7962373 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 63bcedc000 > ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java > 6c73dc54a7 > ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java > 5868d4dd56 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > dbf9363d11 > ql/src/java/org/apache/hadoop/hive/ql/plan/BasicStatsWork.java a4e770ce95 > ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsNoJobTask.java > 946c300750 > ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java b48379013d > ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 78f48b169a > ql/src/java/org/apache/hadoop/hive/ql/stats/fs/FSStatsAggregator.java > d84cf136d5 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > 89354a2d34 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > ecc464418d > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > 50f873a013 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java > 2599ab103e > > > Diff: https://reviews.apache.org/r/65415/diff/2/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
