----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65241/#review196257 -----------------------------------------------------------
Ship it! Ship It! - Peter Vary On Jan. 24, 2018, 3:41 p.m., Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65241/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2018, 3:41 p.m.) > > > Review request for hive, Peter Vary and Adam Szita. > > > Bugs: HIVE-18496 > https://issues.apache.org/jira/browse/HIVE-18496 > > > Repository: hive-git > > > Description > ------- > > The following methods of IMetaStoreClient are covered by this test. > - void createIndex(Index, Table) > - boolean dropIndex(String, String, String, boolean) > - void alter_index(String, String, String, Index) > > The test covers not just the happy pathes, but the edge cases as well. > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddAlterDropIndexes.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65241/diff/3/ > > > Testing > ------- > > Run the tests > > > Thanks, > > Marta Kuczora > >
