----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65241/#review195900 -----------------------------------------------------------
Thanks for this patch Marta, it looks good! I've made a few recommendations only standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddAlterDropIndexes.java Lines 678 (patched) <https://reviews.apache.org/r/65241/#comment275254> For handling future bug fixes more easily we could use consistent notation for these TODOs, see line 343. standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddAlterDropIndexes.java Lines 876-880 (patched) <https://reviews.apache.org/r/65241/#comment275252> If you'd like to shorten this one, I can recommend something like this: cols.stream().collect( Collectors.toMap(col->col.getName(), col->col) ).get("id") - Adam Szita On Jan. 19, 2018, 3:17 p.m., Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65241/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2018, 3:17 p.m.) > > > Review request for hive, Peter Vary and Adam Szita. > > > Bugs: HIVE-18496 > https://issues.apache.org/jira/browse/HIVE-18496 > > > Repository: hive-git > > > Description > ------- > > The following methods of IMetaStoreClient are covered by this test. > - void createIndex(Index, Table) > - boolean dropIndex(String, String, String, boolean) > - void alter_index(String, String, String, Index) > > The test covers not just the happy pathes, but the edge cases as well. > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddAlterDropIndexes.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65241/diff/1/ > > > Testing > ------- > > Run the tests > > > Thanks, > > Marta Kuczora > >
