> On Jan. 25, 2018, 11:37 a.m., Marta Kuczora wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java > > Lines 762-765 (patched) > > <https://reviews.apache.org/r/65284/diff/2/?file=1945147#file1945147line762> > > > > Is this the same use case as in the > > testListPartitionsByFilterEmptyFilter test? If it is, I think it is enough > > to have only one test for this use case.
Removed redundant case > On Jan. 25, 2018, 11:37 a.m., Marta Kuczora wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java > > Lines 1028-1031 (patched) > > <https://reviews.apache.org/r/65284/diff/2/?file=1945147#file1945147line1028> > > > > What is the expected behaviour in this case? Should the > > getNumPartitionsByFilter return 0 or an other value? Added missing assertion - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65284/#review196236 ----------------------------------------------------------- On Jan. 25, 2018, 1:47 p.m., Adam Szita wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65284/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2018, 1:47 p.m.) > > > Review request for hive, Marta Kuczora and Peter Vary. > > > Bugs: HIVE-18484 > https://issues.apache.org/jira/browse/HIVE-18484 > > > Repository: hive-git > > > Description > ------- > > Create tests to cover listPartition(s) methods > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65284/diff/3/ > > > Testing > ------- > > > Thanks, > > Adam Szita > >
