----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65284/#review195996 -----------------------------------------------------------
That is a hugh number of tests. Might add some more. Please check if the proposed ones are valid standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java Lines 145 (patched) <https://reviews.apache.org/r/65284/#comment275479> This is strange :) What is the puprose of this? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java Lines 181 (patched) <https://reviews.apache.org/r/65284/#comment275488> nit: _ standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java Lines 192 (patched) <https://reviews.apache.org/r/65284/#comment275496> nit: Java 8? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java Lines 290 (patched) <https://reviews.apache.org/r/65284/#comment275497> Is this needed? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java Lines 303 (patched) <https://reviews.apache.org/r/65284/#comment275498> Is this needed? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java Lines 360 (patched) <https://reviews.apache.org/r/65284/#comment275499> Maybe a case, when there is no result? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java Lines 435 (patched) <https://reviews.apache.org/r/65284/#comment275501> nit: newline? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java Lines 442 (patched) <https://reviews.apache.org/r/65284/#comment275502> nit: newline? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java Lines 524 (patched) <https://reviews.apache.org/r/65284/#comment275503> nit: checkstyle? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java Lines 623 (patched) <https://reviews.apache.org/r/65284/#comment275507> Shouldn't we check the results? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java Lines 662 (patched) <https://reviews.apache.org/r/65284/#comment275504> NoDb test case? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java Lines 701 (patched) <https://reviews.apache.org/r/65284/#comment275505> Shouldn't we check the results? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java Lines 708 (patched) <https://reviews.apache.org/r/65284/#comment275506> Shouldn't we check the results? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java Lines 794 (patched) <https://reviews.apache.org/r/65284/#comment275508> What happens with empty ("") filter? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java Lines 810 (patched) <https://reviews.apache.org/r/65284/#comment275511> What are the allowed keywords? - OR - AND - ? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java Lines 815 (patched) <https://reviews.apache.org/r/65284/#comment275510> What happens with filter like this: "YYyy=\"2017\""? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java Lines 1061 (patched) <https://reviews.apache.org/r/65284/#comment275512> Do we want to use the result? :) - Peter Vary On Jan. 23, 2018, 9:34 a.m., Adam Szita wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65284/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2018, 9:34 a.m.) > > > Review request for hive, Marta Kuczora and Peter Vary. > > > Bugs: HIVE-18484 > https://issues.apache.org/jira/browse/HIVE-18484 > > > Repository: hive-git > > > Description > ------- > > Create tests to cover listPartition(s) methods > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65284/diff/1/ > > > Testing > ------- > > > Thanks, > > Adam Szita > >
