> On Jan. 22, 2018, 12:35 p.m., Adam Szita wrote: > > This change looks good! I only spotted some small code-duplications that we > > may want to clean up.
Thanks a lot Adam for the review. > On Jan. 22, 2018, 12:35 p.m., Adam Szita wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetListIndexes.java > > Lines 312-329 (patched) > > <https://reviews.apache.org/r/65240/diff/1/?file=1942598#file1942598line312> > > > > We may want to separate the common code parts into helper/checker > > methods here and then call with that with different num values. Thanks for the hint, I fixed it. - Marta ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65240/#review195891 ----------------------------------------------------------- On Jan. 24, 2018, 1:46 p.m., Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65240/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2018, 1:46 p.m.) > > > Review request for hive, Peter Vary and Adam Szita. > > > Bugs: HIVE-18498 > https://issues.apache.org/jira/browse/HIVE-18498 > > > Repository: hive-git > > > Description > ------- > > The following methods of IMetaStoreClient are covered by this test. > - Index getIndex(String, String, String) > - List<Index> listIndexes(String, String, short) > - List<String> listIndexNames(String, String, short) > > The test covers not just the happy pathes, but the edge cases as well. > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetListIndexes.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65240/diff/2/ > > > Testing > ------- > > Run the tests > > > Thanks, > > Marta Kuczora > >
