----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65240/ -----------------------------------------------------------
(Updated Jan. 24, 2018, 1:46 p.m.) Review request for hive, Peter Vary and Adam Szita. Changes ------- Addressed the review findings. - Eliminated code duplication - Create a list of indexes in the setup and used them in the tests. Also some refactoring was needed due to this change. Bugs: HIVE-18498 https://issues.apache.org/jira/browse/HIVE-18498 Repository: hive-git Description ------- The following methods of IMetaStoreClient are covered by this test. - Index getIndex(String, String, String) - List<Index> listIndexes(String, String, short) - List<String> listIndexNames(String, String, short) The test covers not just the happy pathes, but the edge cases as well. Diffs (updated) ----- standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetListIndexes.java PRE-CREATION Diff: https://reviews.apache.org/r/65240/diff/2/ Changes: https://reviews.apache.org/r/65240/diff/1-2/ Testing ------- Run the tests Thanks, Marta Kuczora