-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62360/#review185867
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/parse/repl/CopyUtils.java
Lines 121 (patched)
<https://reviews.apache.org/r/62360/#comment262216>

    we cant set this to false all paths that are source paths as there might be 
for ex: 5 paths all of which are sourcePath but during copy the 5th one fails 
we cant set the first 4 to be moved to CM as CM would not have anything for them



ql/src/java/org/apache/hadoop/hive/ql/parse/repl/CopyUtils.java
Lines 123 (patched)
<https://reviews.apache.org/r/62360/#comment262219>

    we cant throw this as the fileNotFound might be a source file but the file 
list will contain both source and CM files.


- anishek


On Sept. 20, 2017, 9:41 p.m., Daniel Dai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62360/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2017, 9:41 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> See HIVE-16898
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ReplCopyTask.java 54746d3 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/repl/CopyUtils.java 28e7bcb 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java
>  dd9296a 
> 
> 
> Diff: https://reviews.apache.org/r/62360/diff/6/
> 
> 
> Testing
> -------
> 
> Manually test it with debugger: setup a breakpoint right before copy, and 
> drop table in another session.
> 
> 
> Thanks,
> 
> Daniel Dai
> 
>

Reply via email to