> On Sept. 19, 2017, 5:46 a.m., anishek wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/repl/CopyUtils.java
> > Lines 120 (patched)
> > <https://reviews.apache.org/r/62360/diff/3/?file=1828690#file1828690line120>
> >
> > May be i am missing something but even when we are using the CM path in
> > copyAndVerify towards the last, the file from CM itself might be deleted
> > via the CM cleaner thread, in that case the doCopy will quietly fail and
> > move on rather than failing replication.
It is handled by copyAndVerify. If the source file is not there, getting
checksum of source file will throw exception:
catch (FileNotFoundException e) {
if (!srcFile.isUseSourcePath()) {
// If we already use CM path, that means the CM path is expired, throw
exception
// as there is no remedy
throw e;
}
}
Anyway, this is refactor in the new patch.
- Daniel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62360/#review185643
-----------------------------------------------------------
On Sept. 19, 2017, 7:11 a.m., Daniel Dai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62360/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2017, 7:11 a.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> See HIVE-16898
>
>
> Diffs
> -----
>
> metastore/src/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java
> 88d6a7a
> ql/src/java/org/apache/hadoop/hive/ql/exec/ReplCopyTask.java 54746d3
> ql/src/java/org/apache/hadoop/hive/ql/parse/repl/CopyUtils.java 28e7bcb
>
>
> Diff: https://reviews.apache.org/r/62360/diff/4/
>
>
> Testing
> -------
>
> Manually test it with debugger: setup a breakpoint right before copy, and
> drop table in another session.
>
>
> Thanks,
>
> Daniel Dai
>
>
