----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60006/#review177910 -----------------------------------------------------------
Thank you so much Zsombor for working on this patch. This is going to help us alot on running patches on newer branches without manual interaction to create a new profile. There's still some work to do, but I'm glad we're starting to have progress on this. Btw, looking at the code, I think you need to edit jenkins-execute-build.sh to send the branch name? testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java Line 322 (original), 324 (patched) <https://reviews.apache.org/r/60006/#comment251613> Should we check that BRANCH is not empty before starting the test? Is this a required argument or optional? If it is optional, what branch will use as default? We're removing the branch option from the profiles, so this will not exist. testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java Lines 108 (patched) <https://reviews.apache.org/r/60006/#comment251614> Why is a workingDirectoryWrapper needed? Currently, Ptest works on a 'working' directory for any branch detected on the profile. Why do we want to change that for different branches? - Sergio Pena On June 13, 2017, 2:28 p.m., Barna Zsombor Klara wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60006/ > ----------------------------------------------------------- > > (Updated June 13, 2017, 2:28 p.m.) > > > Review request for hive, Sergio Pena and Siddharth Seth. > > > Bugs: HIVE-14746 > https://issues.apache.org/jira/browse/HIVE-14746 > > > Repository: hive-git > > > Description > ------- > > HIVE-14746: Remove branch and repositories from profiles by sending them from > ptest-client > > > Diffs > ----- > > > testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java > 8e2604d372ac29b94445b269f08423b058308efe > > testutils/ptest2/src/main/java/org/apache/hive/ptest/api/request/TestStartRequest.java > 8deed52ae0307d4fc075654a4d75e6cb09a5d9db > > testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java > b2c61f03c5bf5f170894141848c89fc26129115a > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java > 1cdfdb309acd8282e593abd7ed10c87721926c60 > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/CloudExecutionContextProvider.java > 8b82497bdaf43694e0e1552e125b5ffdce40f56c > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/ExecutionContext.java > b09de1d4d930cf2d4d26b500f3457cea3fffa9ce > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/FixedExecutionContextProvider.java > f7b50d6a61962d2727b5181215be9de2e64b05b7 > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/WorkingDirWrapper.java > PRE-CREATION > > testutils/ptest2/src/test/java/org/apache/hive/ptest/api/server/TestTestExecutor.java > a4a789b579305d9ed573d8c1fd0b6ce75787d50f > > testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestConfiguration.java > 848faf27af1ed8945d7013b6562bab544605e4bc > > > Diff: https://reviews.apache.org/r/60006/diff/2/ > > > Testing > ------- > > Manually tested the PTestClient with and without the branch argument. > Updated and ran the unit tests. > > > Thanks, > > Barna Zsombor Klara > >
