----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60006/#review177720 -----------------------------------------------------------
Thanks for the patch Zsombor! It would be nice to have automatic testing for new branches without extra configuration work! Just minor questions. Thanks for your work! Peter testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java Lines 118-120 (patched) <https://reviews.apache.org/r/60006/#comment251444> Is it possible to have a request without branch? Should not we use a default for this so we have a cleaner directory layout? testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java Lines 107 (patched) <https://reviews.apache.org/r/60006/#comment251442> We might be able to used File object here. What do you think? testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/WorkingDirWrapper.java Lines 49 (patched) <https://reviews.apache.org/r/60006/#comment251440> It might be useful to use File objects instead of the path string. What do you think? testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/WorkingDirWrapper.java Lines 59 (patched) <https://reviews.apache.org/r/60006/#comment251441> We do not use this method. Do we need it? - Peter Vary On June 12, 2017, 3:31 p.m., Barna Zsombor Klara wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60006/ > ----------------------------------------------------------- > > (Updated June 12, 2017, 3:31 p.m.) > > > Review request for hive, Sergio Pena and Siddharth Seth. > > > Bugs: HIVE-14746 > https://issues.apache.org/jira/browse/HIVE-14746 > > > Repository: hive-git > > > Description > ------- > > HIVE-14746: Remove branch and repositories from profiles by sending them from > ptest-client > > > Diffs > ----- > > > testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java > 8e2604d372ac29b94445b269f08423b058308efe > > testutils/ptest2/src/main/java/org/apache/hive/ptest/api/request/TestStartRequest.java > 8deed52ae0307d4fc075654a4d75e6cb09a5d9db > > testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java > b2c61f03c5bf5f170894141848c89fc26129115a > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java > 1cdfdb309acd8282e593abd7ed10c87721926c60 > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/CloudExecutionContextProvider.java > 8b82497bdaf43694e0e1552e125b5ffdce40f56c > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/ExecutionContext.java > b09de1d4d930cf2d4d26b500f3457cea3fffa9ce > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/FixedExecutionContextProvider.java > f7b50d6a61962d2727b5181215be9de2e64b05b7 > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/WorkingDirWrapper.java > PRE-CREATION > > testutils/ptest2/src/test/java/org/apache/hive/ptest/api/server/TestTestExecutor.java > a4a789b579305d9ed573d8c1fd0b6ce75787d50f > > testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestConfiguration.java > 848faf27af1ed8945d7013b6562bab544605e4bc > > > Diff: https://reviews.apache.org/r/60006/diff/1/ > > > Testing > ------- > > Manually tested the PTestClient with and without the branch argument. > Updated and ran the unit tests. > > > Thanks, > > Barna Zsombor Klara > >
