> On March 3, 2017, 11:54 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java
> > Lines 170 (patched)
> > <https://reviews.apache.org/r/56810/diff/5/?file=1655198#file1655198line173>
> >
> >     tezWork.getAllWork().get(0).setGatheringStats(true);

This will throw NPE. Note that ProcessAnalyzeTable will be fired when it 
matches TS while GenTezUtils will be fined when it matches RS. 
ProcessAnalyzeTable will be fired before any map work is generated. Thus, it 
will not have any work at this place.


- pengcheng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56810/#review167896
-----------------------------------------------------------


On March 2, 2017, 10:37 p.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56810/
> -----------------------------------------------------------
> 
> (Updated March 2, 2017, 10:37 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-15903
> 
> 
> Diffs
> -----
> 
>   itests/src/test/resources/testconfiguration.properties b01ebd8 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 
> 3e749eb 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java 7f5fdff 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java 
> c13a404 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 0872e53 
>   ql/src/test/queries/clientpositive/column_table_stats.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/column_table_stats_orc.q PRE-CREATION 
>   ql/src/test/results/clientpositive/llap/column_table_stats.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientpositive/llap/column_table_stats_orc.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientpositive/perf/query14.q.out 9821180 
>   ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out 20c330a 
>   ql/src/test/results/clientpositive/tez/explainanalyze_5.q.out ee9affb 
>   ql/src/test/results/clientpositive/tez/explainuser_3.q.out 74e4693 
> 
> 
> Diff: https://reviews.apache.org/r/56810/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>

Reply via email to