----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56810/#review167896 -----------------------------------------------------------
Can you also add golden file updates in RB, wanna go through those changes as well. ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java Lines 202-205 (patched) <https://reviews.apache.org/r/56810/#comment239870> This should be done in ProcessAnalyzeTable. ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java Lines 170 (patched) <https://reviews.apache.org/r/56810/#comment239871> tezWork.getAllWork().get(0).setGatheringStats(true); ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java Lines 189 (patched) <https://reviews.apache.org/r/56810/#comment239873> this is not needed.. since at this point partitions has already been read. ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java Lines 190 (patched) <https://reviews.apache.org/r/56810/#comment239872> LOG.debug() ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java Lines 198 (patched) <https://reviews.apache.org/r/56810/#comment239874> Better comment: For ORC, there is no Tez Job. ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java Lines 212 (patched) <https://reviews.apache.org/r/56810/#comment239875> Remove this. Both incorrect as well as misplaced. - Ashutosh Chauhan On March 2, 2017, 10:37 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56810/ > ----------------------------------------------------------- > > (Updated March 2, 2017, 10:37 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > HIVE-15903 > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties b01ebd8 > ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java > 3e749eb > ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java 7f5fdff > ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java > c13a404 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 0872e53 > ql/src/test/queries/clientpositive/column_table_stats.q PRE-CREATION > ql/src/test/queries/clientpositive/column_table_stats_orc.q PRE-CREATION > ql/src/test/results/clientpositive/llap/column_table_stats.q.out > PRE-CREATION > ql/src/test/results/clientpositive/llap/column_table_stats_orc.q.out > PRE-CREATION > ql/src/test/results/clientpositive/perf/query14.q.out 9821180 > ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out 20c330a > ql/src/test/results/clientpositive/tez/explainanalyze_5.q.out ee9affb > ql/src/test/results/clientpositive/tez/explainuser_3.q.out 74e4693 > > > Diff: https://reviews.apache.org/r/56810/diff/5/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
