> On Feb. 27, 2017, 6:01 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java, > > line 452 > > <https://reviews.apache.org/r/56995/diff/2/?file=1647474#file1647474line452> > > > > Can't the variable declartion be `Queue`, same for the other > > declarations below. > > Vihang Karajgaonkar wrote: > We can declare it as a Queue, but the implementation of the queue needs > to be thread-safe since multiple threads are going to operate on the queue at > the same time. I thought of declaring it as a concurrentQueue would make it > more clear and understandable without any performance implications. Is there > a particular advantage you can think of declaring it as queue? This also > makes sure that we have a compile time type check to ensure that calling > methods are using concurrent queues. > > Sahil Takiar wrote: > In case we want to change the type of queue being used, e.g. a > `BlockingQueue` could be used, or a custom concurrent queue.
Changed the type to Queue - Vihang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56995/#review166898 ----------------------------------------------------------- On Feb. 27, 2017, 6:44 p.m., Vihang Karajgaonkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56995/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2017, 6:44 p.m.) > > > Review request for hive, Aihua Xu, Ashutosh Chauhan, and Sergio Pena. > > > Bugs: HIVE-15879 > https://issues.apache.org/jira/browse/HIVE-15879 > > > Repository: hive-git > > > Description > ------- > > HIVE-15879 : Fix HiveMetaStoreChecker.checkPartitionDirs method > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java > 7c94c95f00492467ba27dedc9ce513e13c85ea61 > > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveMetaStoreChecker.java > 35f52cd522e0e48a333e30966245bec65cc2ec9c > > Diff: https://reviews.apache.org/r/56995/diff/ > > > Testing > ------- > > Tested using existing and newly added test cases > > > Thanks, > > Vihang Karajgaonkar > >
