----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56995/#review166898 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java (line 443) <https://reviews.apache.org/r/56995/#comment238986> Can't the variable declartion be `Queue`, same for the other declarations below. ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java (lines 520 - 526) <https://reviews.apache.org/r/56995/#comment238988> Not sure I follow this logic, why are two queues necessary? ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java (line 546) <https://reviews.apache.org/r/56995/#comment238987> Usually better to `throw new HiveException(e)` so that the full stack-trace is included. - Sahil Takiar On Feb. 24, 2017, 7:20 p.m., Vihang Karajgaonkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56995/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2017, 7:20 p.m.) > > > Review request for hive, Aihua Xu, Ashutosh Chauhan, and Sergio Pena. > > > Bugs: HIVE-15879 > https://issues.apache.org/jira/browse/HIVE-15879 > > > Repository: hive-git > > > Description > ------- > > HIVE-15879 : Fix HiveMetaStoreChecker.checkPartitionDirs method > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java > 7c94c95f00492467ba27dedc9ce513e13c85ea61 > > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveMetaStoreChecker.java > 35f52cd522e0e48a333e30966245bec65cc2ec9c > > Diff: https://reviews.apache.org/r/56995/diff/ > > > Testing > ------- > > Tested using existing and newly added test cases > > > Thanks, > > Vihang Karajgaonkar > >
