----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2762/#review3316 -----------------------------------------------------------
Looks good overall. Please update build.properties and resubmit. Thanks! trunk/build.properties <https://reviews.apache.org/r/2762/#comment7404> For the time being we need to stick with 0.20.1 as the default Hadoop version against which Hive is tested, but we should start using 0.23.0 for the security tests, and should ensure that all tests pass when run against 0.23.0. Please set hadoop.version to 0.20.1 and hadoop.security.version to 0.23.0, and ensure that all tests pass when run as "ant test -Dhadoop.version=0.23.0". Also, I added 0.23.0 to the cloudera and facebook hive-deps mirrors, so please reference those locations instead. - Carl On 2011-11-07 23:55:47, Tom White wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2762/ > ----------------------------------------------------------- > > (Updated 2011-11-07 23:55:47) > > > Review request for hive. > > > Summary > ------- > > See https://issues.apache.org/jira/browse/HIVE-2468 > > > This addresses bug HIVE-2468. > https://issues.apache.org/jira/browse/HIVE-2468 > > > Diffs > ----- > > trunk/build.properties 1196775 > > trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java > 1196775 > > trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableOutputFormat.java > 1196775 > > trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHFileOutputFormat.java > 1196775 > trunk/service/src/java/org/apache/hadoop/hive/service/HiveServer.java > 1196775 > trunk/shims/build.xml 1196775 > trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java > 1196775 > trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java > 1196775 > trunk/shims/src/0.23/java/org/apache/hadoop/fs/ProxyFileSystem.java > PRE-CREATION > trunk/shims/src/0.23/java/org/apache/hadoop/fs/ProxyLocalFileSystem.java > PRE-CREATION > trunk/shims/src/0.23/java/org/apache/hadoop/hive/shims/EmptyShim.java > PRE-CREATION > trunk/shims/src/0.23/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java > PRE-CREATION > > trunk/shims/src/0.23/java/org/apache/hadoop/hive/shims/HiveHarFileSystem.java > PRE-CREATION > trunk/shims/src/0.23/java/org/apache/hadoop/hive/shims/Jetty23Shims.java > PRE-CREATION > > trunk/shims/src/0.23/java/org/apache/hadoop/hive/thrift/DelegationTokenIdentifier.java > PRE-CREATION > > trunk/shims/src/0.23/java/org/apache/hadoop/hive/thrift/DelegationTokenSecretManager.java > PRE-CREATION > > trunk/shims/src/0.23/java/org/apache/hadoop/hive/thrift/DelegationTokenSelector.java > PRE-CREATION > trunk/shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java > 1196775 > trunk/shims/src/common/java/org/apache/hadoop/hive/shims/ShimLoader.java > 1196775 > > Diff: https://reviews.apache.org/r/2762/diff > > > Testing > ------- > > > Thanks, > > Tom > >
