> On Dec. 20, 2016, 8:56 p.m., Thejas Nair wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java, > > line 175 > > <https://reviews.apache.org/r/54826/diff/1/?file=1588285#file1588285line175> > > > > is there any generic way to find this from FileSystem api ? these > > configs are specific to HDFS. > > But i guess we don't need this if we go with storing only the signature > > (see following comment)
I checked HDFS code, doesn't seems another way to do that > On Dec. 20, 2016, 8:56 p.m., Thejas Nair wrote: > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestReplChangeManager.java, > > line 56 > > <https://reviews.apache.org/r/54826/diff/1/?file=1588283#file1588283line56> > > > > with recent changes by Vaibhav to ProxyFileSystem, local files would > > also have checksums. Can we switch to local files, so that test speed is > > better (local fs might be more reliable than minidfs, as it has less parts > > to it!) setXAttr will need HDFS - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54826/#review159520 ----------------------------------------------------------- On Dec. 16, 2016, 11:14 p.m., Daniel Dai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54826/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2016, 11:14 p.m.) > > > Review request for hive and Thejas Nair. > > > Repository: hive-git > > > Description > ------- > > See HIVE-15448 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 9064e49 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestReplChangeManager.java > PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > f7b2ed7 > metastore/src/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java > PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 6aca1b7 > > Diff: https://reviews.apache.org/r/54826/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Dai > >
