----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49919/#review141920 -----------------------------------------------------------
I took a look at the unit test and the use of Mockito, the approach there looks good, just two minor comments. beeline/src/test/org/apache/hive/beeline/TestBufferedRows.java (lines 37 - 39) <https://reviews.apache.org/r/49919/#comment207347> You can delete this, right? Since it looks like the method is empty. beeline/src/test/org/apache/hive/beeline/TestBufferedRows.java (line 42) <https://reviews.apache.org/r/49919/#comment207351> Could you add a more descriptive name to this method? Also some comments about the test is trying to test would be helpful - Sahil Takiar On July 11, 2016, 8:28 p.m., Vihang Karajgaonkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49919/ > ----------------------------------------------------------- > > (Updated July 11, 2016, 8:28 p.m.) > > > Review request for hive, Mohit Sabharwal, Sergio Pena, Sahil Takiar, and > Thejas Nair. > > > Repository: hive-git > > > Description > ------- > > HIVE-14135 : beeline output not formatted correctly for large column widths > > > Diffs > ----- > > beeline/pom.xml a720d0835314221ec3bd9e8d354d148498ff794c > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java > 5aaa38527734d46de037352ff51e54e0ae1cede0 > beeline/src/java/org/apache/hive/beeline/BufferedRows.java > 962c5319bb7e6e448979e1cef80a086cadd2ecc6 > beeline/src/test/org/apache/hive/beeline/TestBufferedRows.java PRE-CREATION > > Diff: https://reviews.apache.org/r/49919/diff/ > > > Testing > ------- > > > Thanks, > > Vihang Karajgaonkar > >
