> On Feb. 16, 2016, 7:38 p.m., Prasanth_J wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java, > > line 1523 > > <https://reviews.apache.org/r/40415/diff/3/?file=1240578#file1240578line1523> > > > > Then why provide this interface? Is it client's responsibility as to > > when to use this interface?
Yes :) > On Feb. 16, 2016, 7:38 p.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java, line 484 > > <https://reviews.apache.org/r/40415/diff/3/?file=1240581#file1240581line484> > > > > Is it intentional? Stacktrace will be lost. Yeah, this exception is not very useful, it's usually just the fact that the FS doesn't support file IDs. > On Feb. 16, 2016, 7:38 p.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileFormatProxy.java, line > > 41 > > <https://reviews.apache.org/r/40415/diff/3/?file=1240583#file1240583line41> > > > > what is the byteBuffer arg contain? What is the return type? It's > > unclear from the function signature. I think it will be better to do the > > conversion from SplitInfo to ByteBuffer just right before we send it across > > the wire. SplitInfo can be generic across file formats. changed the return type; the arg is file metadata, documented on the interface, I renamed it for clarity > On Feb. 16, 2016, 7:38 p.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java, line 625 > > <https://reviews.apache.org/r/40415/diff/3/?file=1240584#file1240584line625> > > > > nit. are there multiple caches? yes, by conf. Usually there would only be one. Renamed for clarity. > On Feb. 16, 2016, 7:38 p.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java, line 1002 > > <https://reviews.apache.org/r/40415/diff/3/?file=1240584#file1240584line1002> > > > > same as above. is it required to drop the stacktrace and just print the > > message? Yes, stacktrace is annoying and pointless :) In case if there's some FS issue, the other (non-ID) API will probably also fail and produce a proper stack trace - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40415/#review119116 ----------------------------------------------------------- On Feb. 26, 2016, 5:04 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40415/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2016, 5:04 a.m.) > > > Review request for hive, Gopal V, Prasanth_J, and Vikram Dixit Kumaraswamy. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java e868500 > > metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataHandler.java > bd4e188 > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > b5c4d1d > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > cb092d1 > > metastore/src/java/org/apache/hadoop/hive/metastore/filemeta/OrcFileMetadataHandler.java > 1b388aa > orc/src/java/org/apache/orc/impl/InStream.java b1c6de5 > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 520ae74 > ql/src/java/org/apache/hadoop/hive/ql/io/HdfsUtils.java af64fc8 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileFormatProxy.java > ef76723 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java d175d2d > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcNewInputFormat.java 2782d7e > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java aa1c925 > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java > 6f84708 > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcSplitElimination.java > 7a93b54 > storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java > dc71db4 > > storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java > be5e67b > > Diff: https://reviews.apache.org/r/40415/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
