----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40415/#review116839 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 1102) <https://reviews.apache.org/r/40415/#comment177940> I actaully initially created PairOfLong and then renamed the fields for clarity. I looked at it; it is immutable and a pain to use for just having a pair of long. ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 1964) <https://reviews.apache.org/r/40415/#comment177943> Added a comment. Basically, in the PPD case, we don't parse the footers, so we don't care. Also having PPD implies that footers are correct, otherwise PPD wouldn't be able to work. ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 2055) <https://reviews.apache.org/r/40415/#comment177944> Will try that ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 2061) <https://reviews.apache.org/r/40415/#comment177945> This is after modification ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 2116) <https://reviews.apache.org/r/40415/#comment177946> not really, it's owned by one thread. I just want to get the bytes out w/o copy. - Sergey Shelukhin On Nov. 18, 2015, 12:23 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40415/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2015, 12:23 a.m.) > > > Review request for hive, Gopal V, Prasanth_J, and Vikram Dixit Kumaraswamy. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 953e52c > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > c5e7a5f > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > aa96f77 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 46862da > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 488d923 > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java > ec90481 > storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java > dc71db4 > storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgument.java > d70b3b0 > > storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java > eeff131 > > Diff: https://reviews.apache.org/r/40415/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
