----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38503/ -----------------------------------------------------------
(Updated Sept. 30, 2015, 9:38 p.m.) Review request for hive, Ashutosh Chauhan and John Pullokkaran. Changes ------- address Lefty and John's comments. Repository: hive-git Description ------- Right now table names can only be "[a-zA-z_0-9]+". This patch tries to investigate how much change there should be if we would like to support special characters, e.g., "/" in table names. Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f29da2 metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java ee20430 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a80f686 metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java f88f4dd metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java bc0f6e3 ql/src/java/org/apache/hadoop/hive/ql/Driver.java 43159c6 ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 210736b ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java be5a593 ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java fadd074 ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c78e8f4 ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 52ed4a3 ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java 4966d89 ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 8b7a2e8 ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 1e2feaa ql/src/test/queries/clientnegative/special_character_in_tabnames_1.q PRE-CREATION ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q PRE-CREATION ql/src/test/queries/clientpositive/special_character_in_tabnames_2.q PRE-CREATION ql/src/test/queries/clientpositive/special_character_in_tabnames_3.q PRE-CREATION ql/src/test/results/clientnegative/special_character_in_tabnames_1.q.out PRE-CREATION ql/src/test/results/clientpositive/special_character_in_tabnames_1.q.out PRE-CREATION ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out PRE-CREATION ql/src/test/results/clientpositive/special_character_in_tabnames_3.q.out PRE-CREATION Diff: https://reviews.apache.org/r/38503/diff/ Testing ------- Thanks, pengcheng xiong
