----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34897/#review88242 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java (line 976) <https://reviews.apache.org/r/34897/#comment140666> Is your intention here to change the table alias in the schema of the child too? ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverterPostProc.java (line 55) <https://reviews.apache.org/r/34897/#comment140664> It seems that joinOpToAlias is never used. Could it be removed? ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverterPostProc.java (line 110) <https://reviews.apache.org/r/34897/#comment140665> Blank space - Jesús Camacho Rodríguez On June 16, 2015, 9:55 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34897/ > ----------------------------------------------------------- > > (Updated June 16, 2015, 9:55 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > in ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java, line 477, > when aliases contains empty string "" and key is an empty string "" too, it > assumes that aliases contains key. This will trigger incorrect PPD. To > reproduce it, apply the HIVE-10455 and run cbo_subq_notin.q. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java > 9c21238 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverterPostProc.java > e7c8342 > > Diff: https://reviews.apache.org/r/34897/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
