----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34897/#review87979 -----------------------------------------------------------
Pengcheng, I think many of the changes that you made are already included in HiveOpConverterPostProc.java (e.g. create the BaseSrc structure). We agreed we would use that rule for such things, as we may get rid of those data structures once we do the optimizations in Calcite, and that way it is easier to isolate the code. Could you leave in the HiveOpConverter only the changes that are necessary? - Jesús Camacho Rodríguez On June 1, 2015, 5:58 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34897/ > ----------------------------------------------------------- > > (Updated June 1, 2015, 5:58 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > in ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java, line 477, > when aliases contains empty string "" and key is an empty string "" too, it > assumes that aliases contains key. This will trigger incorrect PPD. To > reproduce it, apply the HIVE-10455 and run cbo_subq_notin.q. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java > 4f19caf > > Diff: https://reviews.apache.org/r/34897/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
