----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35323/#review87640 -----------------------------------------------------------
ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDummyTxnManager.java <https://reviews.apache.org/r/35323/#comment140036> Could you explicitly set hive.txn.manager to org.apache.hadoop.hive.ql.lockmgr.DummyTxnManager in HiveConf? so make sure there will be no surprise in future? Why do you think holding a Shared lock in user current database is a problem? it should not stop others from acquiring Shared locks on this table, right? Or are you expecting that others might want to acquire an Exclusive lock on the database to change it(e.g. rename)? I am not sure and also have not tested that in other DBMS like mysql, when a user is under a database, that database is allowed to be renamed or not. - Chaoyu Tang On June 10, 2015, 9:08 p.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35323/ > ----------------------------------------------------------- > > (Updated June 10, 2015, 9:08 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-10972 DummyTxnManager always locks the current database in shared mode, > which is incorrect. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java ea04415 > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java e75a90a > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java > 4f86dd9 > ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDummyTxnManager.java > 5abb729 > > Diff: https://reviews.apache.org/r/35323/diff/ > > > Testing > ------- > > > Thanks, > > Aihua Xu > >
