> On June 10, 2015, 8:44 p.m., Damien Carol wrote: > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java, line 54 > > <https://reviews.apache.org/r/35323/diff/1/?file=982259#file982259line54> > > > > Is this change connected to this bug?
Not directly related to the bug but I found such issue when I created the new unit test which will throw NPE. Do you suggest to fix saprately? - Aihua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35323/#review87448 ----------------------------------------------------------- On June 10, 2015, 8:35 p.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35323/ > ----------------------------------------------------------- > > (Updated June 10, 2015, 8:35 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-10972 DummyTxnManager always locks the current database in shared mode, > which is incorrect. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java > ea04415bc0054e8689a118d2d726ede2ad1e3b80 > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java > e75a90a449ef7db95f5808302607fa5f04c9b8c8 > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java > 4f86dd9aa539ebdbd2412d4cbcf857dd3e614858 > ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDummyTxnManager.java > 5abb729fe18d49591857c4ede2d9307274448c62 > > Diff: https://reviews.apache.org/r/35323/diff/ > > > Testing > ------- > > > Thanks, > > Aihua Xu > >
