[
https://issues.apache.org/jira/browse/HIVE-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119740#comment-13119740
]
John Sichi commented on HIVE-2470:
----------------------------------
Looks good; I noted a couple of typos in the Javadoc. If you give me an
updated patch with those corrected, I'll run through test.
But one question: do you have any test that verifies that constant folding is
actually taking place as expected? EXPLAIN doesn't tell, so it would be good
to have a regression test in place that fails if someone accidentally breaks
the optimization.
> Improve support for Constant Object Inspectors
> ----------------------------------------------
>
> Key: HIVE-2470
> URL: https://issues.apache.org/jira/browse/HIVE-2470
> Project: Hive
> Issue Type: Improvement
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Attachments: HIVE-1360.part2.patch, HIVE-2470.patch,
> HIVE-2470.patch.3, HIVE-2470.patch.4
>
>
> ConstantObjectInspectors are nice but they need to be more widely supported
> and used. In particular,
> * More functions need to be using them.
> * There need to be facilities for propagating constness.
> * Support for complex types must be added.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
