[ 
https://issues.apache.org/jira/browse/HIVE-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118232#comment-13118232
 ] 

Ashutosh Chauhan commented on HIVE-2380:
----------------------------------------

@John

bq.     I would be a lot more comfortable with this patch if it included 
testing of real binary data (not just strings encoded as binary) at the QL 
level end-to-end, getting stored in a table, queried, passed through UDF's, 
etc. (not just the Java unit test level of serdes) since that is the intended 
use case
Added following tests:
* ba_table1.q basic test which tests a) binary type works correctly in grammar 
b) string can be cast into binary c) binary can be stored in a table d) binary 
data can be loaded back again and queried d) order-by on a binary key
* ba_table2.q All the test in ba_test1.q + using LazyBinarySerde instead of 
LazySimpleSerde
* ba_table3.q All the tests of ba_table1.q + test for a group-by and 
aggregation on a binary key.
* ba_table_udfs.q this query tests all the udfs provided to work with binary 
works.
* ba_table_union.q this query tests ba_table1.q + nested queries with multiple 
operations on binary data types + union on binary types 
* binary_table_colserde.q - Everything in ba_table1.q + columnar serde in 
RCFILE.
* binary_table_bincolserde.q  Tests everything in binary_table_colserde.q + 
uses LazyBinaryColumnarSerde
* load_binary_data.q this query loads native binary data, stores in a table and 
then queries it. Note that string.txt contains binary data. Also uses transform 
clause and then length udf on binary fields.


bq.     need negative tests for attempting illegal conversions to/from binary
Added whole bunch of negative tests of form invalid_cast_to_binary_[1..6].q and 
invalid_cast_from_binary_[1..6].q to tests illegal conversion attempts.

bq.     please rename this issue since we're going with BINARY instead of 
BYTEARRAY
Done.
                
> Add Binary Datatype in Hive
> ---------------------------
>
>                 Key: HIVE-2380
>                 URL: https://issues.apache.org/jira/browse/HIVE-2380
>             Project: Hive
>          Issue Type: New Feature
>          Components: Serializers/Deserializers
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>         Attachments: hive-2380.patch, hive-2380_1.patch
>
>
> Add bytearray as a primitive data type.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to