[
https://issues.apache.org/jira/browse/HIVE-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115081#comment-13115081
]
jirapos...@reviews.apache.org commented on HIVE-2380:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1586/#review2076
-----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
<https://reviews.apache.org/r/1586/#comment4695>
I thought we decided an explicit cast would be required even for
string<-->binary?
trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFConcat.java
<https://reviews.apache.org/r/1586/#comment4699>
@Description annotation for this class needs to be updated.
trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLength.java
<https://reviews.apache.org/r/1586/#comment4698>
@Description annotation for this class needs to be updated.
trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSubstr.java
<https://reviews.apache.org/r/1586/#comment4700>
@Description annotation for this class needs to be updated.
trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToBinary.java
<https://reviews.apache.org/r/1586/#comment4697>
This UDF class needs an @Description annotation.
trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToBinary.java
<https://reviews.apache.org/r/1586/#comment4696>
The CAST should have parentheses, so
CAST(x AS BINARY)
(this applies to the existing code in GenericUDFTimestamp too)
trunk/ql/src/test/queries/clientpositive/ba_table1.q
<https://reviews.apache.org/r/1586/#comment4701>
Use ORDER BY on a key for all queries to guarantee test determinism. Also,
since test output keeps getting bigger and bigger, it's best to filter down to
just a few rows to keep it easier to review and manage.
(This comment applies to all tests in this patch.)
trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java
<https://reviews.apache.org/r/1586/#comment4708>
Is there a test for this somewhere? It seems like a case where we need
base64.
trunk/serde/src/java/org/apache/hadoop/hive/serde2/columnar/LazyBinaryColumnarSerDe.java
<https://reviews.apache.org/r/1586/#comment4715>
I'm not sure about the original connection between UTF and strings here
(was something forcing a UTF encoding), but is it valid for arbitrary binary
data?
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
<https://reviews.apache.org/r/1586/#comment4716>
Since we decided we're not going to support implicit conversions, these
don't belong here, right?
- John
On 2011-09-18 05:52:41, Ashutosh Chauhan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1586/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-18 05:52:41)
bq.
bq.
bq. Review request for hive.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This patch adds bytearray as a new datatype in Hive.
bq.
bq.
bq. This addresses bug HIVE-2380.
bq. https://issues.apache.org/jira/browse/HIVE-2380
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
1172168
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
1172168
bq.
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
1172168
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1172168
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java
1172168
bq.
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
1172168
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFConcat.java 1172168
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLength.java 1172168
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSubstr.java 1172168
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java 1172168
bq.
trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToBinary.java
PRE-CREATION
bq. trunk/ql/src/test/queries/clientpositive/ba_table1.q PRE-CREATION
bq. trunk/ql/src/test/queries/clientpositive/ba_table2.q PRE-CREATION
bq. trunk/ql/src/test/queries/clientpositive/ba_table_udfs.q PRE-CREATION
bq. trunk/ql/src/test/results/clientpositive/ba_table1.q.out PRE-CREATION
bq. trunk/ql/src/test/results/clientpositive/ba_table2.q.out PRE-CREATION
bq. trunk/ql/src/test/results/clientpositive/ba_table_udfs.q.out
PRE-CREATION
bq. trunk/serde/if/serde.thrift 1172168
bq. trunk/serde/src/gen/thrift/gen-cpp/serde_constants.h 1172168
bq. trunk/serde/src/gen/thrift/gen-cpp/serde_constants.cpp 1172168
bq.
trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/Constants.java
1172168
bq. trunk/serde/src/gen/thrift/gen-php/serde/serde_constants.php 1172168
bq.
trunk/serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py
1172168
bq. trunk/serde/src/gen/thrift/gen-rb/serde_constants.rb 1172168
bq. trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java
1172168
bq.
trunk/serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java
1172168
bq.
trunk/serde/src/java/org/apache/hadoop/hive/serde2/columnar/LazyBinaryColumnarSerDe.java
1172168
bq.
trunk/serde/src/java/org/apache/hadoop/hive/serde2/columnar/LazyBinaryColumnarStruct.java
1172168
bq. trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyBinary.java
PRE-CREATION
bq. trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
1172168
bq. trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java
1172168
bq.
trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyBinaryObjectInspector.java
PRE-CREATION
bq.
trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
1172168
bq.
trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryBinary.java
PRE-CREATION
bq.
trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryFactory.java
1172168
bq.
trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java
1172168
bq.
trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java
1172168
bq.
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
1172168
bq.
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
1172168
bq.
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java
1172168
bq.
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/BinaryObjectInspector.java
PRE-CREATION
bq.
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaBinaryObjectInspector.java
PRE-CREATION
bq.
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java
1172168
bq.
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java
1172168
bq.
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
1172168
bq.
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/SettableBinaryObjectInspector.java
PRE-CREATION
bq.
trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableBinaryObjectInspector.java
PRE-CREATION
bq.
trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java
1172168
bq. trunk/serde/src/test/org/apache/hadoop/hive/serde2/TestStatsSerde.java
1172168
bq.
trunk/serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/MyTestClass.java
1172168
bq.
trunk/serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/TestBinarySortableSerDe.java
1172168
bq.
trunk/serde/src/test/org/apache/hadoop/hive/serde2/columnar/TestLazyBinaryColumnarSerDe.java
1172168
bq.
trunk/serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazyPrimitive.java
1172168
bq.
trunk/serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazySimpleSerDe.java
1172168
bq.
trunk/serde/src/test/org/apache/hadoop/hive/serde2/lazybinary/MyTestClassBigger.java
1172168
bq.
trunk/serde/src/test/org/apache/hadoop/hive/serde2/lazybinary/TestLazyBinarySerDe.java
1172168
bq.
trunk/serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestObjectInspectorConverters.java
1172168
bq.
trunk/serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestStandardObjectInspectors.java
1172168
bq.
bq. Diff: https://reviews.apache.org/r/1586/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Added and updated unit tests.
bq. Added new system tests.
bq.
bq.
bq. Thanks,
bq.
bq. Ashutosh
bq.
bq.
> Add ByteArray Datatype
> ----------------------
>
> Key: HIVE-2380
> URL: https://issues.apache.org/jira/browse/HIVE-2380
> Project: Hive
> Issue Type: New Feature
> Components: Serializers/Deserializers
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Attachments: hive-2380.patch, hive-2380_1.patch
>
>
> Add bytearray as a primitive data type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
