[
https://issues.apache.org/jira/browse/HIVE-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113048#comment-13113048
]
jirapos...@reviews.apache.org commented on HIVE-2461:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2023/
-----------------------------------------------------------
(Updated 2011-09-23 00:08:56.319090)
Review request for hive, Yongqiang He and Ning Zhang.
Changes
-------
Thanks Yongqiang. I didn't like the name either, but the only other one I
could come up with was finalize which I didn't want to use for obvious reasons.
Summary
-------
I added a method called finishPerfLogger, which is called at the end of the run
method in Driver to allow PerfLogger subclasses to perform any cleanup tasks or
logging that requires all the perf stats to have been calculated. It takes as
parameters a Log, to be consistent with the other methods in PerfLogger, as
well as the QueryPlan from Driver in order to allow information such as the
query ID to be logged.
I should note that finishPerfLogger is not guaranteed to run. This was my
intention.
This addresses bug HIVE-2461.
https://issues.apache.org/jira/browse/HIVE-2461
Diffs (updated)
-----
trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1173881
trunk/ql/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java 1173881
Diff: https://reviews.apache.org/r/2023/diff
Testing
-------
I created a subclass of PerfLogger which implemented the finishPerfLogger
method, and verified it was successfully called and executed.
I also ran some of the unit tests to verify nothing was broken.
Thanks,
Kevin
> Add method to PerfLogger to perform cleanup/final steps.
> --------------------------------------------------------
>
> Key: HIVE-2461
> URL: https://issues.apache.org/jira/browse/HIVE-2461
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2461.1.patch.txt, HIVE-2461.2.patch.txt
>
>
> I think a method added to PerfLogger to perform cleanup/final steps would be
> very useful. For example, it could be used to close any database connections
> created as part of a PerfLogger subclass, or to perform logging that requires
> all perf values to first be calculated.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
