[
https://issues.apache.org/jira/browse/HIVE-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113047#comment-13113047
]
jirapos...@reviews.apache.org commented on HIVE-2461:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2023/#review2030
-----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java
<https://reviews.apache.org/r/2023/#comment4579>
one nitpick is that do you think call this function a 'close' will be more
clear? we already have a PerfLogEnd().
- Yongqiang
On 2011-09-22 23:54:37, Kevin Wilfong wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2023/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-22 23:54:37)
bq.
bq.
bq. Review request for hive, Yongqiang He and Ning Zhang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I added a method called finishPerfLogger, which is called at the end of
the run method in Driver to allow PerfLogger subclasses to perform any cleanup
tasks or logging that requires all the perf stats to have been calculated. It
takes as parameters a Log, to be consistent with the other methods in
PerfLogger, as well as the QueryPlan from Driver in order to allow information
such as the query ID to be logged.
bq.
bq. I should note that finishPerfLogger is not guaranteed to run. This was my
intention.
bq.
bq.
bq. This addresses bug HIVE-2461.
bq. https://issues.apache.org/jira/browse/HIVE-2461
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1173881
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java 1173881
bq.
bq. Diff: https://reviews.apache.org/r/2023/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. I created a subclass of PerfLogger which implemented the finishPerfLogger
method, and verified it was successfully called and executed.
bq.
bq. I also ran some of the unit tests to verify nothing was broken.
bq.
bq.
bq. Thanks,
bq.
bq. Kevin
bq.
bq.
> Add method to PerfLogger to perform cleanup/final steps.
> --------------------------------------------------------
>
> Key: HIVE-2461
> URL: https://issues.apache.org/jira/browse/HIVE-2461
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2461.1.patch.txt
>
>
> I think a method added to PerfLogger to perform cleanup/final steps would be
> very useful. For example, it could be used to close any database connections
> created as part of a PerfLogger subclass, or to perform logging that requires
> all perf values to first be calculated.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
