----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1295/ -----------------------------------------------------------
(Updated 2011-08-09 23:44:00.972625) Review request for hive and Ning Zhang. Changes ------- Added the hive.exec.failure.hooks property to hive-default.xml Summary ------- I added a new type of hook, which will be run when a job fails. This addresses bug HIVE-2346. https://issues.apache.org/jira/browse/HIVE-2346 Diffs (updated) ----- trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1155569 trunk/conf/hive-default.xml 1155569 trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1155569 trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/HookContext.java 1155569 Diff: https://reviews.apache.org/r/1295/diff Testing ------- I ran the TestCliDriver and TestNegativeCliDriver test suites and verified they passed. In addition, I created a sample hook, which simply logged that it was run. I verified it was run on a failure, but not when a job succeeded. Thanks, Kevin