----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1295/#review1370 -----------------------------------------------------------
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/1295/#comment3144> Kevin, can you add this parameter to conf/hive-default.xml? We should add all newly introduced parameters to that file. Otherwise it looks good to me. - Ning On 2011-08-09 22:01:28, Kevin Wilfong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1295/ > ----------------------------------------------------------- > > (Updated 2011-08-09 22:01:28) > > > Review request for hive and Ning Zhang. > > > Summary > ------- > > I added a new type of hook, which will be run when a job fails. > > > This addresses bug HIVE-2346. > https://issues.apache.org/jira/browse/HIVE-2346 > > > Diffs > ----- > > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1155569 > trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1155569 > trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/HookContext.java 1155569 > > Diff: https://reviews.apache.org/r/1295/diff > > > Testing > ------- > > I ran the TestCliDriver and TestNegativeCliDriver test suites and verified > they passed. > > In addition, I created a sample hook, which simply logged that it was run. I > verified it was run on a failure, but not when a job succeeded. > > > Thanks, > > Kevin > >
