[
https://issues.apache.org/jira/browse/HIVE-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081960#comment-13081960
]
jirapos...@reviews.apache.org commented on HIVE-2346:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1295/
-----------------------------------------------------------
(Updated 2011-08-09 22:01:28.619424)
Review request for hive and Ning Zhang.
Changes
-------
Made the changes requested by nzhang.
Regarding the change ArrayList --> List, I had copied that code from the
analogous methods for Post and Pre Exec hooks. So I made the corresponding
changes in those methods too.
Summary
-------
I added a new type of hook, which will be run when a job fails.
This addresses bug HIVE-2346.
https://issues.apache.org/jira/browse/HIVE-2346
Diffs (updated)
-----
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1155569
trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1155569
trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/HookContext.java 1155569
Diff: https://reviews.apache.org/r/1295/diff
Testing
-------
I ran the TestCliDriver and TestNegativeCliDriver test suites and verified they
passed.
In addition, I created a sample hook, which simply logged that it was run. I
verified it was run on a failure, but not when a job succeeded.
Thanks,
Kevin
> Add hooks to run when execution fails.
> --------------------------------------
>
> Key: HIVE-2346
> URL: https://issues.apache.org/jira/browse/HIVE-2346
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2346.1.patch.txt
>
>
> Currently, when a query fails, the Post Execution Hooks are not run.
> Adding hooks to be run when a query fails could allow for better logging etc.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
