[
https://issues.apache.org/jira/browse/HIVE-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081944#comment-13081944
]
[email protected] commented on HIVE-2346:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1295/#review1364
-----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
<https://reviews.apache.org/r/1295/#comment3082>
As a convention, we should declare the variable as interface (List in this
case) rather than implementation (ArrayList).
trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
<https://reviews.apache.org/r/1295/#comment3086>
comments are not correct: post execution --> failure
- Ning
On 2011-08-04 19:06:43, Kevin Wilfong wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1295/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-04 19:06:43)
bq.
bq.
bq. Review request for hive and Ning Zhang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I added a new type of hook, which will be run when a job fails.
bq.
bq.
bq. This addresses bug HIVE-2346.
bq. https://issues.apache.org/jira/browse/HIVE-2346
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1153966
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1153966
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/HookContext.java
1153966
bq.
bq. Diff: https://reviews.apache.org/r/1295/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. I ran the TestCliDriver and TestNegativeCliDriver test suites and verified
they passed.
bq.
bq. In addition, I created a sample hook, which simply logged that it was run.
I verified it was run on a failure, but not when a job succeeded.
bq.
bq.
bq. Thanks,
bq.
bq. Kevin
bq.
bq.
> Add hooks to run when execution fails.
> --------------------------------------
>
> Key: HIVE-2346
> URL: https://issues.apache.org/jira/browse/HIVE-2346
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2346.1.patch.txt
>
>
> Currently, when a query fails, the Post Execution Hooks are not run.
> Adding hooks to be run when a query fails could allow for better logging etc.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
