-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1144/
-----------------------------------------------------------

(Updated 2011-07-28 06:11:18.101615)


Review request for hive.


Changes
-------

Patch rebased


Summary
-------

Few code improvements in the ql and serde packages.
1) Little performance Improvements 
2) Null checks to avoid NPEs
3) Effective varaible management.


This addresses bug HIVE-2080.
    https://issues.apache.org/jira/browse/HIVE-2080


Diffs (updated)
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java 
1151731 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 
1151731 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FilterOperator.java 1151731 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java 1151731 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 1151731 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java 
1151731 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java 1151731 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 
1151731 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java 1151731 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/UnionOperator.java 1151731 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ASTNode.java 1151731 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 
1151731 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 1151731 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
1151731 
  
trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDeField.java
 1151731 
  
trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDeFieldType.java
 1151731 
  
trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDeFunction.java
 1151731 

Diff: https://reviews.apache.org/r/1144/diff


Testing
-------

All unit test passed


Thanks,

chinna

Reply via email to